Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the close button into the modals #2737

Closed
marcoambrosini opened this issue Jun 7, 2022 · 2 comments · Fixed by #2738
Closed

Move the close button into the modals #2737

marcoambrosini opened this issue Jun 7, 2022 · 2 comments · Fixed by #2738
Assignees
Labels
1. to develop Accepted and waiting to be taken care of component Component discussion and/or suggestion design Design, UX, interface and interaction design

Comments

@marcoambrosini
Copy link
Contributor

marcoambrosini commented Jun 7, 2022

The close buttons should be visible within the modal windows.
cc @jancborchardt & @nimishavijay

Screenshot 2022-06-07 at 15 31 02

proposed alternative (note that the close button is hovered there):
Screenshot 2022-06-07 at 15 36 47

@marcoambrosini marcoambrosini self-assigned this Jun 7, 2022
@marcoambrosini marcoambrosini added design Design, UX, interface and interaction design discussion Need advices, opinions or ideas on this topic labels Jun 7, 2022
@jancborchardt
Copy link
Contributor

Yes, absolutely. :) This comes up very often as an issue.
We only need to make sure that this works with the existing modals if they have content in them, like e.g. Talk group creation, firstrunwizard or password confirmation, etc.

@marcoambrosini
Copy link
Contributor Author

How about making it a non required prop for the time being then so it's not a breaking change and we can use it right away?

@marcoambrosini marcoambrosini added 1. to develop Accepted and waiting to be taken care of component Component discussion and/or suggestion and removed discussion Need advices, opinions or ideas on this topic labels Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of component Component discussion and/or suggestion design Design, UX, interface and interaction design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants