Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6540 Feature: Adds TikTok Provider #6546

Closed
wants to merge 8 commits into from

Conversation

sdairs
Copy link

@sdairs sdairs commented Jan 29, 2023

☕️ Reasoning

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

#6540

@vercel
Copy link

vercel bot commented Jan 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 29, 2023 at 1:37PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
next-auth-docs ⬜️ Ignored (Inspect) Jan 29, 2023 at 1:37PM (UTC)

@github-actions github-actions bot added core Refers to `@auth/core` providers labels Jan 29, 2023
@balazsorban44
Copy link
Member

Actually, I realize we already had: #2720, but could not merge because I was unable to test. I wanted to create an application, but TikTok hasn't approved it. :sadblob: Do you have some suggestions on how to get an app approved? 🙏 Or if you have an already-approved dev app I could loan to test this out, you could reach out to me on Twitter maybe.

return {
id: profile.open_id,
name: profile.display_name,
image: profile.avatar_url
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
image: profile.avatar_url
image: profile.avatar_url,
email: profile.email ?? null

Do you know if e-mail can be returned?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developers.tiktok.com/doc/tiktok-api-v2-get-user-info/ if you scroll down on this page, there is docs for the User Object - I couldn't find any ref to get an email unfortunately

@sdairs
Copy link
Author

sdairs commented Jan 29, 2023

Yeah it was a nightmare to get an app approved by TikTok. I have one, I'll DM and we can use it to test

client_secret: options.clientSecret,
},
},
userinfo: "https://open-api.tiktok.com/user/info",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angelhodar
Copy link

angelhodar commented Mar 10, 2023

Hey everyone! If you need some help with this PR I can give a helping hand here. I already have a tiktok app that I used for testing, if you want I can change the redirect URL to some testing domain (localhost is not allowed) and pass you the credentials @balazsorban44

@ThangHuuVu
Copy link
Member

close via #8131

@ThangHuuVu ThangHuuVu closed this Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` enhancement New feature or request providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants