-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(providers): TikTok provider #2720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I added some suggestions.
Do note that we plan to release v4 to stable very soon, so it would be nice to get this merged before that.
Could you show some kind of proof of login that shows the returned name
, email
, picture
, or any of those that are actually returned?
We could use that, later on, to refer to, when people are having issues.
Thank you!
Gentle bump @denkristoffer. We will release v4 next week, if this doesn't address my comments, we cannot merge it and therefore will be closed. |
An accompanying docs page should also be added at https://github.com/nextauthjs/docs/tree/main/docs/providers |
Thank you for the bump. I didn't mean to close this, I will try to get to this in time for v4. Rebasing on the |
What are you looking for here? A demo website? |
Basically just a screenshot of the returned data by the |
src/providers/tiktok.ts
Outdated
client[custom.http_options] = (_url, options) => { | ||
return { ...options, followRedirect: true } | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'll update the httpOptions
to expose followRedirect
as well, so we hopefully can get rid of the openid-client
custom
import.
If you merge |
I've tried to register an App, it had some caveats, that should be mentioned in the docs. Would be appreciated if you opened a PR regarding this #2720 (comment) First of all, it seems like you cannot use |
Great! Docs PR is under way 🙂 TikTok seems to manually approve apps and it can take a few days. |
In that case, could you paste in the logged in result just so I (and future everyone) knows that this provider should work? |
I don't currently have a site using this provider, but I'll try to run it with the demo website later today. |
I don't expect an actual site. do try with the demo app. otherwise how did you even create the PR? 😀 |
I created this for a personal project, but eventually decided against using TikTok for auth since their oauth implementation honestly seemed to change quickly. I couldn't get the demosite working with the provider yesterday because of the oauth client complaining about an "Invalid URL". I will debug and try again tonight, hopefully. |
Unfortunately, if we cannot show proof of login, I will have to close this PR. I'll check back at the end of my day, and if works then, we can merge. Otherwise, I'll close this for now. We can revisit the idea at a later time after v4 has landed in stable. Thank you for your contribution nonetheless. |
anything news?? |
Reasoning 💡
Adds TikTok provider. Their implementation is a bit funky, so there's a bit of customisation.
Checklist 🧢