Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate --sidebar-wrapper-height in pure CSS #360

Merged
merged 4 commits into from
Sep 2, 2021
Merged

Conversation

stevenjoezhang
Copy link
Member

@stevenjoezhang stevenjoezhang commented Aug 29, 2021

PR Checklist

  • The commit message follows guidelines for NexT.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

Issue resolved:

See also #243

What is the new behavior?

  • Link to demo site with this changes:
  • Screenshots with this changes:

Refactor sidebar-inner with flex layout. Completely remove the initSidebarDimension function and --sidebar-wrapper-height

How to use?

In NexT _config.yml:

@coveralls
Copy link

coveralls commented Aug 29, 2021

Coverage Status

Coverage remained the same at 94.468% when pulling 28fa98e on sidebar into c377515 on master.

@stevenjoezhang stevenjoezhang marked this pull request as ready for review August 29, 2021 15:09
@stevenjoezhang stevenjoezhang requested a review from a team August 29, 2021 15:20
@stevenjoezhang
Copy link
Member Author

@tusooa Can you help review this pr? The complex calculations of --sidebar-wrapper-height can be implemented with a more robust CSS flex layout

@stevenjoezhang stevenjoezhang added this to the 8.8.0 milestone Sep 1, 2021
@stevenjoezhang stevenjoezhang merged commit 76bba71 into master Sep 2, 2021
@stevenjoezhang stevenjoezhang deleted the sidebar branch September 2, 2021 15:38
lingyf pushed a commit to lingyf/hexo-theme-next that referenced this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants