Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling for site overview #243

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Conversation

tusooa
Copy link
Contributor

@tusooa tusooa commented Apr 9, 2021

PR Checklist

  • The commit message follows guidelines for NexT.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • N/A Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

Cannot scroll to the topmost for site overview.
site-overview-bad

Issue resolved:

What is the new behavior?

Should be able to scroll to the topmost.

  • Link to demo site with this changes:
  • Screenshots with this changes: site-overview-good

How to use?

No change in configuration needed.

In NexT _config.yml:

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
All committers have signed the CLA.

@tusooa
Copy link
Contributor Author

tusooa commented Apr 9, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Tusooa Zhu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Again, I am not licensing to SAP SE, but NexT. So no.

@njzjz
Copy link
Member

njzjz commented Apr 9, 2021

Please fix the conflicting files or rebase the branch.

@PaperStrike
Copy link
Member

Again, I am not licensing to SAP SE, but NexT. So no.

I believe there was a mistake. It's NexT's now.

@coveralls
Copy link

coveralls commented Apr 12, 2021

Coverage Status

Coverage remained the same at 94.468% when pulling 5108f10 on tusooa:siteov-scroll into d4f97cd on next-theme:master.

@stevenjoezhang stevenjoezhang added this to the 8.4.0 milestone Apr 28, 2021
@stevenjoezhang
Copy link
Member

@tusooa Sorry, there was a problem with the configuration of the CLA, and it has now been updated

@stevenjoezhang stevenjoezhang modified the milestones: 8.4.0, 8.5.0 Apr 30, 2021
@stevenjoezhang stevenjoezhang removed this from the 8.5.0 milestone May 30, 2021
@ljcbaby
Copy link
Member

ljcbaby commented Jun 1, 2021

@tusooa Please check the Pull Request status update

@jiangtj
Copy link

jiangtj commented Jun 1, 2021

@stevenjoezhang This agreement is a bit problematic. For example,

Disputes. This Agreement shall be governed by and construed in accordance with the laws of the State of New York, United States of America, without giving effect to its principles or rules regarding conflicts of laws, other than such principles directing application of New York law. The parties hereby submit to venue in, and jurisdiction of the courts located in New York, New York for purposes relating to this Agreement. In the event that any of the provisions of this Agreement shall be held by a court or other tribunal of competent jurisdiction to be unenforceable, the remaining portions hereof shall remain in full force and effect.

If the United States denies this agreement(although I think unlikely, but after all, it is the United States), then the contributor has the right to take back the code he contributed. This is actually in conflict with the AGPL agreement, and the authorization of the AGPL agreement is irrevocable

I think we only need to inform the contributors in an obvious place, and your code will be provided to the NexT team and used under the AGPL agreement.

@tusooa
Copy link
Contributor Author

tusooa commented Jun 12, 2021

I signed that already. It's saying it's unsigned maybe because GitHub does not connect the committer email to me, and I have no intention to verify that serious email address against GitHub.

@ljcbaby
Copy link
Member

ljcbaby commented Jun 12, 2021

Maybe that's the problem. Can you allow us to resubmit the Commit using your public email address?

@tusooa
Copy link
Contributor Author

tusooa commented Jun 12, 2021 via email

@ljcbaby ljcbaby added this to the 8.6.0 milestone Jun 13, 2021
@ljcbaby ljcbaby self-assigned this Jun 13, 2021
@ljcbaby
Copy link
Member

ljcbaby commented Jun 13, 2021

Perhaps you need to execute the following command to change this commit information.

git commit --amend --author="Tusooa Zhu <[email protected]>"

Reject
I can't push to your repo.

@tusooa
Copy link
Contributor Author

tusooa commented Jun 13, 2021

Perhaps you need to execute the following command to change this commit information.

git commit --amend --author="Tusooa Zhu <[email protected]>"

Reject
I can't push to your repo.

"If checked, users with write access to next-theme/hexo-theme-next can add new commits to your siteov-scroll branch. You can always change this setting later."

I checked to allow edits.

I guess you are pushing to "pr/243" and that's the reason.

@tusooa
Copy link
Contributor Author

tusooa commented Jun 13, 2021

Thanks

</div>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This remove may be wrong

lingyf pushed a commit to lingyf/hexo-theme-next that referenced this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants