-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scrolling for site overview #243
Conversation
Again, I am not licensing to SAP SE, but NexT. So no. |
Please fix the conflicting files or rebase the branch. |
I believe there was a mistake. It's NexT's now. |
@tusooa Sorry, there was a problem with the configuration of the CLA, and it has now been updated |
@tusooa Please check the Pull Request status update |
@stevenjoezhang This agreement is a bit problematic. For example,
If the United States denies this agreement(although I think unlikely, but after all, it is the United States), then the contributor has the right to take back the code he contributed. This is actually in conflict with the AGPL agreement, and the authorization of the AGPL agreement is irrevocable I think we only need to inform the contributors in an obvious place, and your code will be provided to the NexT team and used under the AGPL agreement. |
I signed that already. It's saying it's unsigned maybe because GitHub does not connect the committer email to me, and I have no intention to verify that serious email address against GitHub. |
Maybe that's the problem. Can you allow us to resubmit the Commit using your public email address? |
Yea, of course. Thank you.
…________________________________
From: Ljcbaby ***@***.***>
Sent: Saturday, June 12, 2021 8:11:16 AM
To: next-theme/hexo-theme-next ***@***.***>
Cc: tusooa ***@***.***>; Mention ***@***.***>
Subject: Re: [next-theme/hexo-theme-next] Fix scrolling for site overview (#243)
Maybe that's the problem. Can you allow us to resubmit the Commit using your public email address?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#243 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AACJGYOVR2XXLN2LBDKQ3HLTSNFGJANCNFSM42UCIORA>.
|
Perhaps you need to execute the following command to change this commit information. git commit --amend --author="Tusooa Zhu <[email protected]>" |
"If checked, users with write access to next-theme/hexo-theme-next can add new commits to your siteov-scroll branch. You can always change this setting later." I checked to allow edits. I guess you are pushing to "pr/243" and that's the reason. |
Thanks |
</div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This remove may be wrong
PR Checklist
PR Type
What is the current behavior?
Cannot scroll to the topmost for site overview.
Issue resolved:
What is the new behavior?
Should be able to scroll to the topmost.
How to use?
No change in configuration needed.
In NexT
_config.yml
: