Skip to content
This repository has been archived by the owner on Mar 3, 2021. It is now read-only.

Update to Rails 4.2 / Bootstrap 3 #15

Merged
merged 3 commits into from
May 18, 2015
Merged

Update to Rails 4.2 / Bootstrap 3 #15

merged 3 commits into from
May 18, 2015

Conversation

vosechu
Copy link
Contributor

@vosechu vosechu commented May 18, 2015

  • Update rails in Gemfile
  • Run rake rails:update
  • Fix tests
  • Remove attr_accessible from models (but I didn’t put it back in the
    controllers)
  • Unfix the lazy loader from BigListController
  • Update bootstrap in sass and js
  • Remove trailing whitespace
  • Remove inline and in-page styles
  • Add description for ManyAssets#index
  • Fix indenting in index.html.erb
  • Fix navbar
  • Remove extra css/js
  • Switch to SASS includes per bootstrap-sasss whim

Fixes #14

@vosechu
Update to Rails 4.2 / Bootstrap 3
525f92e 
- Update rails in Gemfile
- Run `rake rails:update`
- Fix tests
- Remove attr_accessible from models (but I didn’t put it back in the
  controllers)
- Unfix the lazy loader from BigListController
- Update bootstrap in sass and js
- Remove trailing whitespace
- Remove inline and in-page styles
- Add description for ManyAssets#index
- Fix indenting in index.html.erb
- Fix navbar 
- Remove extra css/js
- Switch to SASS includes per `bootstrap-sass`s whim
@vosechu
Copy link
Contributor Author

vosechu commented May 18, 2015

Please feel free to undo/change anything with no feelings of guilt whatsoever. I hope that my changes kept the project on the right path, but I know that I had to do some CSS changes that may have violated some of the original goals. I assure you, I have no attachment to them whatsoever. :)

@jasonrclark
Copy link
Contributor

Noticed that we didn't get the Gemfile.lock updates included here. Blew it away locally to rebuild, but you want to include your local edits on that Chuck?

Ran through and almost all the pages are performing similarly to before, and look as good (or better! ✨) than previously. Excellent!

Only exception is "The Loop" was this minor UI change:

Rails 3.2
image

Rails 4.2
image

Both of them to include the <i class="icon-ok"></i> HTML, so I'm betting something in the CSS updates just isn't showing the checkbox widget. From your spelunking, do you know where that'd be coming from @vosechu?

Once again, ❤️ 💖 for doing this! It's been lingering on my todo list for quite a while, and refreshing to have it up to date!

@vosechu
Copy link
Contributor Author

vosechu commented May 18, 2015

Ah! Interesting. Looks like icons changed class from icon-* to glyphicon glyphicon-*. So glyphicon glyphicon-ok or glyphicon glyphicon-ok-circle would work awesomely.

Also, I just did a bundle update yesterday so whatever that yields for a Gemfile.lock should work I think.

@vosechu
Copy link
Contributor Author

vosechu commented May 18, 2015

he says and then immediately commits his Gemfile.lock anyways

@vosechu
Copy link
Contributor Author

vosechu commented May 18, 2015

Also sent in a fix for the glyphicons. Slow day today.

@jasonrclark
Copy link
Contributor

💥 thanks @vosechu!

@vosechu
Copy link
Contributor Author

vosechu commented May 18, 2015

Of course! Happy to help

jasonrclark added a commit that referenced this pull request May 18, 2015
@jasonrclark
Merge pull request #15 from vosechu/rails-42-updates
b3abfce 
Update to Rails 4.2 / Bootstrap 3
@jasonrclark jasonrclark merged commit b3abfce into newrelic:master May 18, 2015
@jasonrclark jasonrclark mentioned this pull request May 18, 2015
Closed
@vosechu
Copy link
Contributor Author

vosechu commented May 18, 2015

Woohoo! Thanks!

@vosechu vosechu deleted the rails-42-updates branch May 18, 2015 22:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to rails 4.2
2 participants
@vosechu @jasonrclark