Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce support for Ruby #204

Merged
merged 8 commits into from
Jun 27, 2024
Merged

Introduce support for Ruby #204

merged 8 commits into from
Jun 27, 2024

Conversation

fallwith
Copy link
Contributor

  • Introduce runtime configuration values for Ruby (these do not yet power any automated checks)
  • Add sam and terraform examples (these are pretty much straight ports of the Python examples)

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.28%. Comparing base (8200a25) to head (a4c8d87).
Report is 1 commits behind head on main.

❗ Current head a4c8d87 differs from pull request most recent head 330328a. Consider uploading reports for the commit 330328a to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   80.34%   81.28%   +0.94%     
==========================================
  Files          24       24              
  Lines        1221     1229       +8     
==========================================
+ Hits          981      999      +18     
+ Misses        175      164      -11     
- Partials       65       66       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fallwith
Introduce support for Ruby
a9ee4be 
- Introduce runtime configuration values for Ruby (these do not yet
  power any automated checks)
- Add sam and terraform examples (these are pretty much straight ports
  of the Python examples)
@fallwith fallwith mentioned this pull request Mar 28, 2024
Closed
fallwith added 3 commits April 3, 2024 14:23
@fallwith
the Ruby template should read 'ruby'
ea82b6a 
.tf typo fix
@fallwith
Ruby: runtime v3.3 is now the default
06fc0f9 
AWS has introduced support for Ruby v3.3, made it the default, and
retained support for v3.2
@fallwith
Ruby runtimes needed a comma separator
3a7fc88 
typo fix
fallwith added 3 commits April 17, 2024 10:52
@fallwith
runtime config: add missing comma to ruby list
8ea5ba7 
Add trailing array comma
@fallwith
path -> paths for Ruby
732a7d3 
2 runtimes are supported now
@fallwith
single Ruby vendor path
a4c8d87 
two runtimes, but a single expected vendor path
@fallwith fallwith mentioned this pull request May 8, 2024
Merged
@chaudharysaket chaudharysaket merged commit 0579170 into newrelic:main Jun 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaudharysaket chaudharysaket chaudharysaket approved these changes

@iamemilio iamemilio Awaiting requested review from iamemilio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fallwith @CLAassistant @chaudharysaket