-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the serverless content for Ruby #16977
Update the serverless content for Ruby #16977
Conversation
Ruby based AWS Lambda functions are now automatically supported by New Relic
|
Hi @fallwith 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). If you add any more commits, you can comment |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi reviewers. I'm on the Ruby agent team. |
Hi @fallwith would you mind signing the CLA one more time? We've updated it and it requires another signature. |
For employees? Odd. Okay, I've signed it. |
@fallwith I made a few edits. Can you scan through and make sure I maintained the integrity of the instructions? Thanks! |
@homelessbirds I've scanned through and everything looks great. Thanks very much for the fixes! |
Great! Thanks for the contribution @fallwith :) |
@@ -36,6 +36,7 @@ New Relic can instrument: | |||
* [Python](https://github.com/newrelic/newrelic-lambda-extension/tree/main/examples/sam/python) | |||
* [Go](https://github.com/newrelic/newrelic-lambda-extension/tree/main/examples/sam/go) | |||
* [Java](https://github.com/newrelic/newrelic-lambda-extension/tree/main/examples/sam/java) | |||
* [Ruby](https://github.com/newrelic/newrelic-lambda-extension/tree/main/examples/sam/ruby) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fallwith @homelessbirds This link seems to be broken (There is no example of SAM for Ruby). I landed here from this doc page: https://docs.newrelic.com/docs/serverless-function-monitoring/aws-lambda-monitoring/enable-lambda-monitoring/instrument-example/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vicentllongo. I apologize for the confusion I have caused. There are multiple New Relic teams and PRs involved with the effort to support Ruby based AWS Lambda functions and I ended up submitting this documentation PR and asking for it to be merged too early.
The linked content for Ruby will appear once newrelic/newrelic-lambda-extension#204 has been merged.
In the meantime, our Ruby Lambda beta test instructions can be used.
Ruby based AWS Lambda functions are now automatically supported by New Relic