Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the serverless content for Ruby #16977

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Update the serverless content for Ruby #16977

merged 5 commits into from
Apr 23, 2024

Conversation

fallwith
Copy link
Contributor

Ruby based AWS Lambda functions are now automatically supported by New Relic

Ruby based AWS Lambda functions are now automatically supported by New
Relic
@CLAassistant
Copy link

CLAassistant commented Apr 17, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

Hi @fallwith 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). If you add any more commits, you can comment netlify build on this PR to update the preview.

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 673d865
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/6626e8fc277157000837146f
😎 Deploy Preview https://deploy-preview-16977--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fallwith
Copy link
Contributor Author

Hi reviewers. I'm on the Ruby agent team.

@homelessbirds
Copy link
Contributor

Hi @fallwith would you mind signing the CLA one more time? We've updated it and it requires another signature.

@fallwith
Copy link
Contributor Author

Hi @fallwith would you mind signing the CLA one more time? We've updated it and it requires another signature.

For employees? Odd. Okay, I've signed it.

@homelessbirds
Copy link
Contributor

@fallwith I made a few edits. Can you scan through and make sure I maintained the integrity of the instructions? Thanks!

@fallwith
Copy link
Contributor Author

@homelessbirds I've scanned through and everything looks great. Thanks very much for the fixes!

@homelessbirds homelessbirds merged commit b1dde85 into newrelic:develop Apr 23, 2024
13 checks passed
@homelessbirds
Copy link
Contributor

Great! Thanks for the contribution @fallwith :)

@fallwith fallwith deleted the serverless_support_for_ruby branch April 29, 2024 19:19
@@ -36,6 +36,7 @@ New Relic can instrument:
* [Python](https://github.com/newrelic/newrelic-lambda-extension/tree/main/examples/sam/python)
* [Go](https://github.com/newrelic/newrelic-lambda-extension/tree/main/examples/sam/go)
* [Java](https://github.com/newrelic/newrelic-lambda-extension/tree/main/examples/sam/java)
* [Ruby](https://github.com/newrelic/newrelic-lambda-extension/tree/main/examples/sam/ruby)
Copy link

@vicentllongo vicentllongo May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vicentllongo. I apologize for the confusion I have caused. There are multiple New Relic teams and PRs involved with the effort to support Ruby based AWS Lambda functions and I ended up submitting this documentation PR and asking for it to be merged too early.

The linked content for Ruby will appear once newrelic/newrelic-lambda-extension#204 has been merged.

In the meantime, our Ruby Lambda beta test instructions can be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants