Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Error Handling for FacebookConnectButton #22

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

arunshenoy99
Copy link
Member

Proposed changes

  1. Return standard error object as an argument to the onFailure function.
  2. Remove console.error's.

This goes with: newfold-labs/wp-module-onboarding#571

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@arunshenoy99 arunshenoy99 changed the title Improve Error Handling for FacebookConnectButton Improve Error Handling for FacebookConnectButton Jun 4, 2024
@ramyakrishnai
Copy link
Collaborator

@manikantakailasa can you please check this PR with your code changes in BH plugin and approve this PR ?

@ramyakrishnai ramyakrishnai merged commit 1bc20fa into main Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants