Merge pull request #22 from newfold-labs/enhance/error-handling

Improve Error Handling for `FacebookConnectButton`
newfold-labs · Jun 5, 2024 · 1bc20fa · 1bc20fa
2 parents c63bbf4 + e362b62
commit 1bc20fa
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/includes/RestApi/FacebookController.php b/includes/RestApi/FacebookController.php
@@ -110,13 +110,13 @@ public function get_fb_details()
             );
         }
         if ( is_string( $fb_details ) && preg_match( '/^token not found!$/', $fb_details ) ) {
-            return new \WP_REST_Response(
-                array(
-                    'status' => 'error',
-                    'details' => 'You are not authorized'
-                ),
-                401
-            );
+			return new \WP_Error(
+				'nfd_module_facebook_error',
+				__( 'Details not found.', 'wp-module-facebook' ),
+				array(
+					'status' => 404,
+				),
+			);
         }
         else {
             return new \WP_REST_Response(

diff --git a/src/components/facebookConnectButton.js b/src/components/facebookConnectButton.js
@@ -54,7 +54,6 @@ const FacebookConnectButton = ({
             if (typeof onFailure === 'function') {
               onFailure(err);
             }
-            console.error(err);
           });
         setFieldValue(res.token);
       })
@@ -63,7 +62,6 @@ const FacebookConnectButton = ({
         if (typeof onFailure === 'function') {
           onFailure(err);
         }
-        console.error(err);
       });
 
   const getProfileData = () => {

diff --git a/src/utils/helper.js b/src/utils/helper.js
@@ -41,7 +41,7 @@ export const getFacebookUserProfileDetails = () => {
       return res?.details;
     })
     .catch((error) => {
-      throw { message: 'failed to load the data', errorMsg: error };
+      throw error;
     });
 };