Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Add config.name type. #143

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Add config.name type. #143

merged 1 commit into from
Jan 23, 2019

Conversation

fimars
Copy link
Contributor

@fimars fimars commented Jan 23, 2019

Ref #131

A little question, any release plan about this?

Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Can you think of a way in which we could make Travis fail if we forget to add a type like this one in the future?

Re releasing, I'll do one now.

@edmorley edmorley merged commit eca80fe into neutrinojs:master Jan 23, 2019
@fimars
Copy link
Contributor Author

fimars commented Jan 24, 2019

There seems to be no good solution, the d.ts file only provides the type of partial code, and it can't take the contents of the unit-test folder as the target of the types test.

I've looked at some popular repo, and they don't have very good practices yet, still has to commit like this.

vuejs/vue@fe2b27f

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

2 participants