This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
feat: Support config.name() setter #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
approved these changes
Jan 14, 2019
There was a problem hiding this comment.
Sorry for the delayed review - thank you for the PR!
TIL about the name option (https://github.com/webpack/webpack/blob/fdb6b139b94273e5b18870262c193a93f65132e8/schemas/WebpackOptions.json#L1981-L1984).
edmorley
suggested changes
Jan 14, 2019
There was a problem hiding this comment.
Sorry just realised, could you add name to the docs here too?
https://github.com/neutrinojs/webpack-chain#config-shorthand-methods
|
Done! the doc has been updated. |
|
Released in webpack-chain v5.1.0: |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nameis also a top-level option in webpack config. This PR addconfig.name()setter for more elegant usage.