Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Provide the same api as config.plugins for config.optimization.minimizer #95

Closed
Airkro opened this issue Sep 1, 2018 · 5 comments
Closed

Comments

@Airkro
Copy link

Airkro commented Sep 1, 2018

example:

config.optimization.minimizer.plugin(name).use(WebpackPlugin, args)
@edmorley
Copy link
Member

edmorley commented Sep 4, 2018

Hi! Yeah I agree the API should match between the two. Though I suppose there's no way to avoid it being a breaking change?

If you'd like to tackle this, we'd gladly accept a PR :-)

@Airkro
Copy link
Author

Airkro commented Oct 9, 2018

v5 is great, only one problem when I use toString().

image

@eliperelman
Copy link
Member

@Airkro what is the problem exactly?

@edmorley
Copy link
Member

edmorley commented Oct 9, 2018

@eliperelman it took me a while to spot it too, but the /* config.plugin('terser') */ should be /* config.optimization.minimizer('terser') */ (guessing perhaps this issue applies to the resolve plugins too?).

@edmorley
Copy link
Member

I fixed the output issue above in #116, which has just been released in 5.0.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants