Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

The inline comment generated by toString() for optimization.minimizer is wrong #115

Closed
edmorley opened this issue Oct 21, 2018 · 2 comments · Fixed by #116
Closed

The inline comment generated by toString() for optimization.minimizer is wrong #115

edmorley opened this issue Oct 21, 2018 · 2 comments · Fixed by #116
Assignees
@edmorley
Labels
bug

Comments

@edmorley
Copy link
Member

See:
#95 (comment)
@edmorley edmorley added the bug label Oct 21, 2018
@edmorley
Copy link
Member Author

Same for resolve.plugins

@edmorley edmorley self-assigned this Oct 21, 2018
@edmorley edmorley mentioned this issue Oct 21, 2018
Merged
edmorley added a commit that referenced this issue Oct 21, 2018
@edmorley
Fix toString() output for alternative types of plugin (#116)
28e8fea 
Previously the helper comments in the `toString()` output were
incorrect for alternative forms of plugins (`optimization.minimizer`
and `resolve.plugins`) and would refer to them as though they were
instances of `config.plugins` instead.

Before:

`/* config.plugin('name') */`

After:

`/* config.optimization.minimizer('name') */`
`/* config.resolve.plugin('name') */`

Fixes #115.
@edmorley
Copy link
Member Author

Released in 5.0.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@edmorley edmorley

Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix toString() output for alternative types of plugin
1 participant
@edmorley