Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Stop using babel-plugin-jsx-pragmatic #827

Merged
merged 2 commits into from
Apr 27, 2018
Merged

Stop using babel-plugin-jsx-pragmatic #827

merged 2 commits into from
Apr 27, 2018

Commits on Apr 27, 2018

  1. Stop using babel-plugin-jsx-pragmatic

    Since:
    * the plugin is not maintained and does not have a version that
      officially supports Babel 7 (it seems to work, but does so by
      pulling in Babel 6 dependencies that would presumably end up
      causing issues in the future)
    * the automatic imports break being able to import other things
      from `React`
    * explicit is better than implicit (`python -m this` <3)
    
    Users will need to add the missing imports when they upgrade to
    Neutrino 9, but the airbnb preset will warn them (if they use it),
    and we'll call it out in the migration guide.
    edmorley committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    b77da34 View commit details
    Browse the repository at this point in the history
  2. preact: Enable eslint-plugin-react if using ESLint

    `@neutrinojs/preact` already had a dependency on `eslint-plugin-react`,
    but wasn't actually using it. Now the React ESLint plugin is enabled
    if an ESLint configuration is found - the same as for the React preset.
    
    This will make it easier for Preact users to realise what changes they
    need to make, now that we're not using `babel-plugin-jsx-pragmatic`.
    
    Fixes #821.
    edmorley committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    b552e40 View commit details
    Browse the repository at this point in the history