This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Stop using babel-plugin-jsx-pragmatic #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also need to change the places in the docs where it says et al:
|
|
Good point :-) |
Since: * the plugin is not maintained and does not have a version that officially supports Babel 7 (it seems to work, but does so by pulling in Babel 6 dependencies that would presumably end up causing issues in the future) * the automatic imports break being able to import other things from `React` * explicit is better than implicit (`python -m this` <3) Users will need to add the missing imports when they upgrade to Neutrino 9, but the airbnb preset will warn them (if they use it), and we'll call it out in the migration guide.
`@neutrinojs/preact` already had a dependency on `eslint-plugin-react`, but wasn't actually using it. Now the React ESLint plugin is enabled if an ESLint configuration is found - the same as for the React preset. This will make it easier for Preact users to realise what changes they need to make, now that we're not using `babel-plugin-jsx-pragmatic`. Fixes #821.
eliperelman
approved these changes
Apr 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since:
Reactpython -m this<3)Also enables
eslint-plugin-reactif using ESLint with@neutrinojs/preact, for parity with the React preset. (This will make it easier for Preact users to realise what changes they need to make, now that we're not usingbabel-plugin-jsx-pragmatic- and fixes #821).