Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF, ENH] Add CBMAEstimator base class #232

Merged
merged 14 commits into from
May 26, 2020
Merged

Commits on May 25, 2020

  1. Configuration menu
    Copy the full SHA
    9e95aa0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    702a8fa View commit details
    Browse the repository at this point in the history

Commits on May 26, 2020

  1. Add CBMAEstimator base class.

    - This base class pulls metadata required by kernel transformer from
    dataset’s metadata into dataset’s coordinate dataframe as part of
    _preprocess_input.
    - Change ALE “n” to “sample_size”
    - Change IBMAEstimator to MetaEstimator. CBMAEstimator inherits from
    this.
    tsalo committed May 26, 2020
    Configuration menu
    Copy the full SHA
    d1b49e6 View commit details
    Browse the repository at this point in the history
  2. Fix example.

    tsalo committed May 26, 2020
    Configuration menu
    Copy the full SHA
    a2f08ee View commit details
    Browse the repository at this point in the history
  3. get_fdata

    tsalo committed May 26, 2020
    Configuration menu
    Copy the full SHA
    6f2645e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7efce21 View commit details
    Browse the repository at this point in the history
  5. ALE works!

    tsalo committed May 26, 2020
    Configuration menu
    Copy the full SHA
    55fc5a6 View commit details
    Browse the repository at this point in the history
  6. Propagate changes throughout CBMA classes.

    - Need to squeeze masker.transform outputs. Unlike apply_mask, which
    returns (n_voxels,) arrays when only one 3D image is provided,
    transform returns (1, n_voxels) arrays.
    - No more monkey-patching pytest for fixtures.
    - Drop custom datasets in CBMA tests because we now require more
    features and mocking up a dummy would be too much effort.
    - Use masker throughout CBMA methods.
    tsalo committed May 26, 2020
    Configuration menu
    Copy the full SHA
    b162060 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ae4b6b9 View commit details
    Browse the repository at this point in the history
  8. Fix style issue.

    tsalo committed May 26, 2020
    Configuration menu
    Copy the full SHA
    05ba7b9 View commit details
    Browse the repository at this point in the history
  9. Fix tests.

    tsalo committed May 26, 2020
    Configuration menu
    Copy the full SHA
    03bcc81 View commit details
    Browse the repository at this point in the history
  10. fix.

    tsalo committed May 26, 2020
    Configuration menu
    Copy the full SHA
    9ff4370 View commit details
    Browse the repository at this point in the history
  11. Reduce scale memory.

    tsalo committed May 26, 2020
    Configuration menu
    Copy the full SHA
    bf8afc0 View commit details
    Browse the repository at this point in the history
  12. Fix the fix of the fix.

    tsalo committed May 26, 2020
    Configuration menu
    Copy the full SHA
    98ee66d View commit details
    Browse the repository at this point in the history