-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF, ENH] Add CBMAEstimator base class #232
Merged
Merged
Commits on May 25, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9e95aa0 - Browse repository at this point
Copy the full SHA 9e95aa0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 702a8fa - Browse repository at this point
Copy the full SHA 702a8faView commit details
Commits on May 26, 2020
-
- This base class pulls metadata required by kernel transformer from dataset’s metadata into dataset’s coordinate dataframe as part of _preprocess_input. - Change ALE “n” to “sample_size” - Change IBMAEstimator to MetaEstimator. CBMAEstimator inherits from this.
Configuration menu - View commit details
-
Copy full SHA for d1b49e6 - Browse repository at this point
Copy the full SHA d1b49e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2f08ee - Browse repository at this point
Copy the full SHA a2f08eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f2645e - Browse repository at this point
Copy the full SHA 6f2645eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7efce21 - Browse repository at this point
Copy the full SHA 7efce21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55fc5a6 - Browse repository at this point
Copy the full SHA 55fc5a6View commit details -
Propagate changes throughout CBMA classes.
- Need to squeeze masker.transform outputs. Unlike apply_mask, which returns (n_voxels,) arrays when only one 3D image is provided, transform returns (1, n_voxels) arrays. - No more monkey-patching pytest for fixtures. - Drop custom datasets in CBMA tests because we now require more features and mocking up a dummy would be too much effort. - Use masker throughout CBMA methods.
Configuration menu - View commit details
-
Copy full SHA for b162060 - Browse repository at this point
Copy the full SHA b162060View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae4b6b9 - Browse repository at this point
Copy the full SHA ae4b6b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05ba7b9 - Browse repository at this point
Copy the full SHA 05ba7b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03bcc81 - Browse repository at this point
Copy the full SHA 03bcc81View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ff4370 - Browse repository at this point
Copy the full SHA 9ff4370View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf8afc0 - Browse repository at this point
Copy the full SHA bf8afc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98ee66d - Browse repository at this point
Copy the full SHA 98ee66dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.