-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF, ENH] Add CBMAEstimator base class #232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This base class pulls metadata required by kernel transformer from dataset’s metadata into dataset’s coordinate dataframe as part of _preprocess_input. - Change ALE “n” to “sample_size” - Change IBMAEstimator to MetaEstimator. CBMAEstimator inherits from this.
- Need to squeeze masker.transform outputs. Unlike apply_mask, which returns (n_voxels,) arrays when only one 3D image is provided, transform returns (1, n_voxels) arrays. - No more monkey-patching pytest for fixtures. - Drop custom datasets in CBMA tests because we now require more features and mocking up a dummy would be too much effort. - Use masker throughout CBMA methods.
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
- Coverage 61.39% 61.32% -0.08%
==========================================
Files 65 65
Lines 4536 4494 -42
==========================================
- Hits 2785 2756 -29
+ Misses 1751 1738 -13
Continue to review full report at Codecov.
|
This was referenced May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #231, closes #194, closes #171 (although studies with missing coordinates would still probably be a problem). References #170 and #195. Supersedes #179.
Regarding #195- this uses masker throughout CBMA methods so that it's at least consistent.
Changes proposed in this pull request:
_preprocess_input
.Estimator.inputs_['coordinates']
now! This is great because we don't need to mess with the actual dataset.Input type checking is not implemented yet for the CBMAEstimator (i.e., it checks against nothing), but this will be helpful when we figure that out.Minimal input type checking is performed (see above).Notes