Clean code by reducing warning and dead code

[alkino]

Warning are for unused variables.
Dead code is the RCS_version and RCS_date that has not been updated since a really long time.

[azure-pipelines]

✔️ 99bb35b -> Azure artifacts URL

[nrnhines]

I'm generally in favor of this. I reviewed the first 34 files but am not sure I did not make mistakes. What I notice is that occasionally an unused variable is used in a commented out line or false #if block. Generally for debugging. Or an error return is ignored. I wonder if these should be preserved for later decisions about what to do about them.

[azure-pipelines]

✔️ 655a4f4 -> Azure artifacts URL

[codecov]

Codecov Report

Attention: Patch coverage is 79.06977% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.07%. Comparing base (d3a3758) to head (7096ba0).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
src/nrncvode/nrndaspk.cpp	50.00%	4 Missing ⚠️
src/parallel/ocbbs.cpp	60.00%	2 Missing ⚠️
src/nrncvode/netcvode.cpp	50.00%	1 Missing ⚠️
src/oc/hoc_init.cpp	0.00%	1 Missing ⚠️
src/oc/hoc_oop.cpp	88.88%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3139   +/-   ##
=======================================
  Coverage   67.06%   67.07%           
=======================================
  Files         571      571           
  Lines      111318   111269   -49     
=======================================
- Hits        74658    74635   -23     
+ Misses      36660    36634   -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[azure-pipelines]

✔️ 4c2f419 -> Azure artifacts URL

[azure-pipelines]

✔️ 185b496 -> Azure artifacts URL

[azure-pipelines]

✔️ d26ea08 -> Azure artifacts URL

[azure-pipelines]

✔️ b4789ad -> Azure artifacts URL

[azure-pipelines]

✔️ c28c65b -> Azure artifacts URL

[azure-pipelines]

✔️ 0393e3c -> Azure artifacts URL

[azure-pipelines]

✔️ 9055679 -> Azure artifacts URL

[sonarcloud]

Quality Gate passed

Issues
77 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[azure-pipelines]

✔️ 7096ba0 -> Azure artifacts URL

[bbpbuildbot]

Logfiles from GitLab pipeline #238071 (:no_entry:) have been uploaded here!

Status and direct links:

• ✅ mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
• ✅ spack_setup
• ✅ build:nmodl
• ✅ build:neuron:nmodl:intel:legacy
• ✅ build:neuron:nmodl:intel:shared
• ✅ build:neuron:nmodl:nvhpc:acc:legacy
• ✅ build:neuron:nmodl:nvhpc:acc:shared
• ✅ build:neuron:nmodl:nvhpc:omp:legacy
• ✅ build:neuron:nmodl:nvhpc:omp
• ✅ test:neuron:nmodl:intel:legacy
• ✅ test:neuron:nmodl:intel:shared
• ✅ test:neuron:nmodl:nvhpc:acc:legacy
• ⛔ test:neuron:nmodl:nvhpc:acc:shared
• ✅ test:neuron:nmodl:nvhpc:omp:legacy
• ✅ test:neuron:nmodl:nvhpc:omp

[nrnhines]

Great job! I'm delighted this has been completed.
I looked through all these changes again and the only issue I noticed was that

void hoc_show_winio(void) {
    int b = (int) chkarg(1, 0., 1.);
#if defined(WIN32)
    hoc_winio_show(b);
#endif

would have one fewer warning if written as

void hoc_show_winio(void) {
#if defined(WIN32)
    int b = (int) chkarg(1, 0., 1.);
    hoc_winio_show(b);
#endif