Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce warnings nrnoc #3160

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Reduce warnings nrnoc #3160

merged 2 commits into from
Nov 8, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Oct 30, 2024

No description provided.

@bbpbuildbot

This comment has been minimized.

Sign in to view
@alkino alkino changed the title Reduce warnings nrnoc WIP: Reduce warnings nrnoc Oct 30, 2024
@alkino alkino changed the title WIP: Reduce warnings nrnoc Reduce warnings nrnoc Oct 30, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #237309 (:white_check_mark:) have been uploaded here!

Status and direct links:

@azure-pipelines Azure Pipelines
Copy link

✔️ d2a26bf -> Azure artifacts URL

1uc
1uc approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't spot anything wrong, though i'm not sure i would if there were.

src/nrnoc/treeset.cpp Show resolved Hide resolved
src/nrnoc/treeset.cpp Show resolved Hide resolved
@alkino alkino merged commit 8c2d119 into cornu/reduce_warnings Nov 8, 2024
13 checks passed
@alkino alkino deleted the cornu/warnings/nrnoc branch November 8, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1uc 1uc 1uc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alkino @bbpbuildbot @1uc