Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for FractionalVolume with surface_fraction=0 on region "I" #2887

Merged
merged 11 commits into from
Jun 1, 2024

Conversation

rgourdine
Copy link
Collaborator

Closes #2810

Copy link

✔️ 4221238 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link
Member

@ramcdougal ramcdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename the test to, say, test_zero_surface_fractional_volume_3d... because without the surface bit it sounds like we're testing zero volume.

@rgourdine rgourdine added the rxd reaction-diffusion label May 31, 2024
@ramcdougal ramcdougal enabled auto-merge (squash) May 31, 2024 19:28
Copy link

✔️ 7d7e6a0 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

sonarcloud bot commented Jun 1, 2024

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
55.2% Duplication on New Code

See analysis details on SonarCloud

Copy link

✔️ 7ea33d6 -> Azure artifacts URL

@ramcdougal ramcdougal merged commit c6aea21 into master Jun 1, 2024
34 of 35 checks passed
@ramcdougal ramcdougal deleted the Zero_FractionalVolume branch June 1, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rxd reaction-diffusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FractionalVolume with surface_fraction=0 does not work for 3d Region
3 participants