-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace hoc_regexp_* by std::regex #2694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice simplification.
✔️ 31205fd -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✔️ ccaeb31 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2694 +/- ##
==========================================
+ Coverage 66.36% 66.42% +0.06%
==========================================
Files 559 558 -1
Lines 108395 108214 -181
==========================================
- Hits 71931 71876 -55
+ Misses 36464 36338 -126 ☔ View full report in Codecov by Sentry. |
because the |
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 3 New issues |
✔️ e027429 -> Azure artifacts URL |
Add an
escape_bracket
because the original parser used<
and>
for[
and]
.