Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always use standard C++ regex #2580

Closed
2 tasks done
ramcdougal opened this issue Oct 16, 2023 · 3 comments · Fixed by #2694
Closed
2 tasks done

always use standard C++ regex #2580

ramcdougal opened this issue Oct 16, 2023 · 3 comments · Fixed by #2694
Assignees

Comments

@ramcdougal
Copy link
Member

ramcdougal commented Oct 16, 2023

Looks like there are two custom regex (or partial regex) implementations: src/oc/regexp.cpp and src/ivos/regexp.cpp.

std::regex has been part of the C++ standard for over a decade. Can we use that?

Remove:

@ramcdougal ramcdougal changed the title replace with standard C++ regex always use standard C++ regex Oct 16, 2023
@pramodk
Copy link
Member

pramodk commented Oct 16, 2023

Linking # #2204. cc'ing @alkino !

@alkino
Copy link
Member

alkino commented Oct 16, 2023

ivos/regex.cpp use an unsupported option std::multiline. But I check all usages in nrn_modeldb_ci, everything is simple and does not need that.

Maybe we can merge it :$. I will look for the other regex.

@alkino
Copy link
Member

alkino commented Nov 10, 2023

Blocked by: BlueBrain/neurodamus#78

@alkino alkino self-assigned this Nov 10, 2023
@alkino alkino linked a pull request Jan 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants