-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Provide instructions for federation API #133
Conversation
✅ Deploy Preview for neurobagel-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all this great documentation @surchs!
The overall order and grouping of the new instructions make a lot of sense to me, and I do feel this separation of the query tool from the main API-graph stack makes things a little easier to understand.
I've added suggestions below which are mostly related to clarity and minor config fixes (it looks like GitHub is hiding a bunch of them under the "hidden conversations"), along with a few questions that may warrant some new issues to address.
Have a look and see what makes sense to you.
A general comment: it looks like our inline capitalization of "Neurobagel" varies a lot across our docs. Maybe worth converging on one standard capitalization (either "neurobagel" or "Neurobagel")?
Co-authored-by: Alyssa Dai <[email protected]>
- terminology - when not to federate
Co-authored-by: Alyssa Dai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One 🍒, otherwise good to go! 🎉 Thanks again for all your work on this @surchs!
Co-authored-by: Alyssa Dai <[email protected]>
Changes proposed in this pull request:
"local federation"
Checklist
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
) (see https://neurobagel.org/contributing/pull_requests for more info)Closes #XXXX