Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document how to run F-API locally #129

Closed
6 tasks done
Tracked by #58
surchs opened this issue Nov 16, 2023 · 1 comment · Fixed by #133
Closed
6 tasks done
Tracked by #58

document how to run F-API locally #129

surchs opened this issue Nov 16, 2023 · 1 comment · Fixed by #133
Assignees
Labels
feat:add The first minimal viable change that implements a new functionality. type:feature Effort to deliver new features, feature changes & improvements

Comments

@surchs
Copy link
Contributor

surchs commented Nov 16, 2023

everything is already running, now you want to see what the rest of world knows

  • first follow regular deploy
  • add a f-API locally manually via docker run
  • query tool needs to point to f-API now: update .env for query tool -> docker compose up again
  • manually make a new .env file (call it something else?), put it somewhere else
  • embed this new page on the overview with a little bit of context: https://neurobagel.org/overview/
  • mention that if the number of local n-APIs increases, show how to add more

for reference: https://miro.com/app/board/uXjVNOZNJ9A=/?share_link_id=768891461417

@surchs surchs transferred this issue from neurobagel/planning Nov 16, 2023
@surchs surchs added feat:add The first minimal viable change that implements a new functionality. type:feature Effort to deliver new features, feature changes & improvements labels Nov 16, 2023
@surchs surchs self-assigned this Nov 16, 2023
@surchs surchs moved this from Specify - Active to Implement - Active in Neurobagel Nov 16, 2023
@surchs
Copy link
Contributor Author

surchs commented Nov 17, 2023

I think deploying a local query tool with n-API + Graph is not a good idea anymore, now that we have the f-API scenario locally. Consider these deployment scenarios:

  • one local node only:
    • deploy 1: 1x n-API, 1x graph, 1x query tool talking to n-API (what we have so far)
  • one local node + remote federation
    • deploy 1: 1x n-API, 1x graph (default would be 1x query tool but that makes little sense)
    • deploy 2: 1x f-API, 1x query tool talking to f-API
  • two local nodes:
    • deploy 1: 1x n-API, 1x graph
    • deploy 2: 1x n-API, 1x graph
    • deploy 3: 1x f-API, 1x query tool

Any time we ship a new version of the n-API images, it doesn't make sense to then

  • shutdown the n-API and update
  • redeploy the n-API stack including the query tool AND THEN
  • shut down the query tool on every n-API stack except one again

Long story short: I propose that we change our deployment configuration recommendation and files like so:

  • deployment recipe "local node": n-API + graph backend
  • deployment recipe "f-API": f-API + query tool
  • deployment recipe "query tool only": query tool (would only be used if you are running a single n-API locally, i.e. the old default)

@surchs surchs moved this from Implement - Active to Implement - Done in Neurobagel Nov 20, 2023
@alyssadai alyssadai moved this from Implement - Done to Review - Active in Neurobagel Nov 21, 2023
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat:add The first minimal viable change that implements a new functionality. type:feature Effort to deliver new features, feature changes & improvements
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant