-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Allow auto to push on protected branch #261
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
=======================================
Coverage 97.90% 97.90%
=======================================
Files 13 13
Lines 717 717
=======================================
Hits 702 702
Misses 15 15 ☔ View full report in Codecov by Sentry. |
Cool PR, thanks @alyssadai! The docs also say that we have to install this plugin first because it is not part of the Would you like to be the first to try out https://github.com/nektos/act and run your proposed workflow setup locally to test? I was planning to look into this tool so that I don't have to keep making senseless pushes to the workflow dir every time we try to add a new workflow there - this looks like the best tool for that |
Pull Request Test Coverage Report for Build 7271907033
💛 - Coveralls |
Thanks for the suggestion @surchs! I've tried it out locally and documented my findings in our wiki. As described in the limitations I noticed, given the current context restrictions we've set up for when a release is actually initiated / published (on That said, I've confirmed by looking at the local job log that the ...
| ℹ info Found plugin using: /snapshot/auto/packages/core/dist/plugins/filter-non-pull-request.js
| ℹ info Found plugin using: /snapshot/auto/packages/core/dist/plugins/filter-non-pull-request.js
| ℹ info Found plugin using: /snapshot/auto/plugins/git-tag/dist/index.js
| ℹ info Found plugin using: /snapshot/auto/plugins/git-tag/dist/index.js
| ℹ info Found plugin using: /snapshot/auto/plugins/released/dist/index.js
| ℹ info Found plugin using: /snapshot/auto/plugins/released/dist/index.js
| ℹ info Found plugin using: /snapshot/auto/plugins/protected-branch/dist/index.js
| ℹ info Found plugin using: /snapshot/auto/plugins/protected-branch/dist/index.js
| ℹ info Found plugin using: /snapshot/auto/plugins/first-time-contributor/dist/index.js
| ℹ info Found plugin using: /snapshot/auto/plugins/first-time-contributor/dist/index.js
| ℹ info Using Filter Non Pull Request Plugin...
| ℹ info Using git-tag Plugin...
| ℹ info Using released Plugin...
| ℹ info Using protected-branch Plugin...
| ℹ info Using first-time-contributor Plugin...
| https://github.com/neurobagel/bagel-cli.git
| ℹ info Options contain repo information.
| ℹ info Initializing GitHub API with:
... so I think we can go ahead and merge this PR! Please approve if you agree :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thanks a lot @alyssadai 🎉 this is going to be very useful across the repos
🚀 PR was released in |
Changes proposed in this pull request:
Here's my attempt at using the
protected-branch
plugin, based on these docs 🤷I also added the
first-time-contributor
plugin since I was updating the list anyways 🙈Checklist
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see https://neurobagel.org/contributing/pull_requests for more info)Closes #XXXX
For new features:
For bug fixes: