Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin to allow auto-release on protected branch #259

Closed
Tracked by #64
alyssadai opened this issue Dec 18, 2023 · 0 comments · Fixed by #261
Closed
Tracked by #64

Add plugin to allow auto-release on protected branch #259

alyssadai opened this issue Dec 18, 2023 · 0 comments · Fixed by #261
Assignees
@alyssadai
Labels
maint:process Improvement to internal processes type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Dec 18, 2023 •
edited
Loading

For plugin, see: https://github.com/intuit/auto/tree/main/plugins/protected-branch

See SFDigitalServices/formio-sfds#265 for example implementation

We are currently using a fine-grained access token to grant permissions for auto-releasing + building the Docker image (see NB_PAT_RELEASE in here), but the problem is that the permissions don't seem to be enough to allow auto to push to a protected main branch.

This issue has been encountered a few times already:

but the problem is that the workarounds/existing documentation to resolve this issue is based on the classic PATs, not the newer fine-grained ones (e.g., https://intuit.github.io/auto/docs/build-platforms/github-actions#running-with-branch-protection)

To avoid having to mess around too much with PATs, using the protected-branch plugin might be the easiest.
@alyssadai alyssadai mentioned this issue Dec 18, 2023
Closed
29 tasks
@alyssadai alyssadai transferred this issue from neurobagel/planning Dec 18, 2023
@alyssadai alyssadai changed the title Add plugin for branch protection magic Add plugin to allow auto-release on protected branch Dec 18, 2023
@alyssadai alyssadai added the flag:schedule Flag issue that should go on the roadmap or backlog. label Dec 18, 2023
@alyssadai alyssadai self-assigned this Dec 19, 2023
@alyssadai alyssadai removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Dec 19, 2023
@alyssadai alyssadai moved this to Implement - Active in Neurobagel Dec 19, 2023
@alyssadai alyssadai added type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs maint:dependency Dependency updates and their version upgrades. maint:process Improvement to internal processes and removed maint:dependency Dependency updates and their version upgrades. labels Dec 19, 2023
@alyssadai alyssadai mentioned this issue Dec 19, 2023
Merged
6 tasks
@alyssadai alyssadai moved this from Implement - Active to Implement - Done in Neurobagel Dec 19, 2023
@surchs surchs moved this from Implement - Done to Review - Active in Neurobagel Dec 19, 2023
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Dec 20, 2023
@alyssadai alyssadai added release Create a release when this PR is merged and removed release Create a release when this PR is merged labels Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssadai alyssadai

Labels
maint:process Improvement to internal processes type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs
Projects
Neurobagel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI] Allow auto to push on protected branch neurobagel/bagel-cli
1 participant
@alyssadai