-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-609 UI: Resize a column in flow table #238
Conversation
/lgtm |
/ok-to-test |
New image: ["quay.io/netobserv/network-observability-console-plugin:6b0ba8e"]. It will expire after two weeks. |
no changes, just rebased |
/ok-to-test |
New image: ["quay.io/netobserv/network-observability-console-plugin:5bdc17b"]. It will expire after two weeks. |
/lgtm |
@Amoghrd following your feedback I fixed the reset. It will now be done on save only. If you cancel nothing happens. I guess an indicator is missing somewhere if you only change the column sizes and try to reset as it seems nothing changed before you save. Let's keep it as is for now. Thanks ! |
/ok-to-test |
New image: ["quay.io/netobserv/network-observability-console-plugin:c904890"]. It will expire after two weeks. |
import * as _ from 'lodash'; | ||
import * as React from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity: do you use something to reorder imports, or was that manual? Just to understand if there's a rationale for this reordering, no problem per se.
BTW I guess it would be cool, and help reduce the number of conflicts, if we all used something to reorder imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from VSCode ``Organize importsusing
Shift` + `Alt` + `O`
We can add sort imports in eslint
https://eslint.org/docs/latest/rules/sort-imports
and maybe need to tweak auto fix
https://github.com/aladdin-add/eslint-plugin/tree/master/packages/autofix
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpinsonneau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add table resize capabilities
Px
on headers%
Screencast_22_11_2022_14.41.47.webm
Based on #236