Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-609 UI: Resize a column in flow table #238

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Nov 22, 2022

Add table resize capabilities

  • Custom (min)sizes are stored in local storage
    • we only force css min size in Px on headers
    • the table behavior will not be affected if min size is lower than the default width in %
  • Table scroll adapts to new total width
  • Reset default columns also reset sizes
Screencast_22_11_2022_14.41.47.webm

Based on #236

@stleerh
Copy link
Contributor

stleerh commented Nov 22, 2022

/lgtm

@Amoghrd
Copy link
Contributor

Amoghrd commented Nov 28, 2022

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 28, 2022
@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-console-plugin:6b0ba8e"]. It will expire after two weeks.

@openshift-ci openshift-ci bot removed the lgtm label Nov 29, 2022
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 29, 2022
@jpinsonneau
Copy link
Contributor Author

no changes, just rebased

@Amoghrd
Copy link
Contributor

Amoghrd commented Nov 30, 2022

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 30, 2022
@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-console-plugin:5bdc17b"]. It will expire after two weeks.

@stleerh
Copy link
Contributor

stleerh commented Dec 1, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 1, 2022
@openshift-ci openshift-ci bot removed the lgtm label Dec 2, 2022
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 2, 2022
@jpinsonneau
Copy link
Contributor Author

@Amoghrd following your feedback I fixed the reset. It will now be done on save only. If you cancel nothing happens.

I guess an indicator is missing somewhere if you only change the column sizes and try to reset as it seems nothing changed before you save. Let's keep it as is for now.

Thanks !

@Amoghrd
Copy link
Contributor

Amoghrd commented Dec 2, 2022

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

New image: ["quay.io/netobserv/network-observability-console-plugin:c904890"]. It will expire after two weeks.

import * as _ from 'lodash';
import * as React from 'react';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity: do you use something to reorder imports, or was that manual? Just to understand if there's a rationale for this reordering, no problem per se.
BTW I guess it would be cool, and help reduce the number of conflicts, if we all used something to reorder imports

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes from VSCode ``Organize importsusingShift` + `Alt` + `O`

We can add sort imports in eslint
https://eslint.org/docs/latest/rules/sort-imports
and maybe need to tweak auto fix
https://github.com/aladdin-add/eslint-plugin/tree/master/packages/autofix

@jotak
Copy link
Member

jotak commented Dec 5, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 5, 2022
@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 5, 2022
@jpinsonneau jpinsonneau merged commit 8886986 into netobserv:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants