Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-608 UI: Reorder columns in flow table #236

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Nov 21, 2022

Add table drag & drop capabilities

Screencast_21_11_2022_14.01.06.webm

@andrew-ronaldson
Copy link

@jpinsonneau Can this be contributed to console as well?
Is this still using the PF table?

@jpinsonneau
Copy link
Contributor Author

@jpinsonneau Can this be contributed to console as well? Is this still using the PF table?

Yes ! However we are using TableComposable whereas console uses legacy one.

I'll take a look at react-table lib to see if we can contribute in both implementations.

@stleerh
Copy link
Contributor

stleerh commented Nov 22, 2022

I did not run this code, so what happens when you resize a column and then add a new column?  Previously, all the columns were in some predefined order, so where will the new column get added?

@jpinsonneau
Copy link
Contributor Author

I did not run this code, so what happens when you resize a column and then add a new column?  Previously, all the columns were in some predefined order, so where will the new column get added?

Reordering from table should also reorder columns in the popup and vice versa.
Custom sizing is kept for the columns you touched, the others just load with their default width.

@openshift-ci openshift-ci bot removed the lgtm label Nov 23, 2022
@jpinsonneau
Copy link
Contributor Author

@stleerh just fixed a bug while testing your case => 3e15f2e
The not selected columns disapeared in the popup after reorder in the table.

To solve that, I move all not selected columns at the end of the list:
Screencast_23_11_2022_10:04:40.webm

@Amoghrd
Copy link
Contributor

Amoghrd commented Nov 28, 2022

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 28, 2022
@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-console-plugin:3545dbd"]. It will expire after two weeks.

@jotak
Copy link
Member

jotak commented Nov 29, 2022

/lgtm
(code review - not tested)

@jpinsonneau
Copy link
Contributor Author

/approve thanks @stleerh & @jotak

@openshift-ci
Copy link

openshift-ci bot commented Nov 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1f9a438 into netobserv:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants