-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-608 UI: Reorder columns in flow table #236
Conversation
@jpinsonneau Can this be contributed to console as well? |
Yes ! However we are using TableComposable whereas console uses legacy one. I'll take a look at react-table lib to see if we can contribute in both implementations. |
I did not run this code, so what happens when you resize a column and then add a new column? Previously, all the columns were in some predefined order, so where will the new column get added? |
Reordering from table should also reorder columns in the popup and vice versa. |
@stleerh just fixed a bug while testing your case => 3e15f2e To solve that, I move all not selected columns at the end of the list: |
/ok-to-test |
New image: ["quay.io/netobserv/network-observability-console-plugin:3545dbd"]. It will expire after two weeks. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpinsonneau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add table drag & drop capabilities
Screencast_21_11_2022_14.01.06.webm