Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support function route methods field #483

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Aug 22, 2023

@Skn0tt Skn0tt self-assigned this Aug 22, 2023
@Skn0tt Skn0tt requested review from a team as code owners August 22, 2023 13:56
@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for open-api ready!

Name Link
🔨 Latest commit b930d21
🔍 Latest deploy log https://app.netlify.com/sites/open-api/deploys/64e4be9d4be54a0008550acd
😎 Deploy Preview https://deploy-preview-483--open-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@klavavej klavavej self-requested a review August 24, 2023 15:42
Copy link
Contributor

@klavavej klavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any new prose so not sure this really needs docs review

list of methods in swagger.yml looks right to me though I'm not sure where to see this in the api reference - I poked around in the deploy preview and couldn't find the new content

@Skn0tt
Copy link
Contributor Author

Skn0tt commented Aug 25, 2023

Agreed, I don't think docs review is necessary for this change per se - but apparently, you're a codeowner for the file.

I had to search really deep in the reference - the change is located in https://deploy-preview-483--open-api.netlify.com/#tag/deploy/operation/createSiteDeploy, buried under a couple more collapsibles:
Screenshot 2023-08-25 at 07 46 25

@Skn0tt Skn0tt merged commit 76eae7f into master Aug 25, 2023
15 checks passed
@Skn0tt Skn0tt deleted the functionroute-methods branch August 25, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants