feat: support function route methods field

netlify · Aug 22, 2023 · b930d21 · b930d21
1 parent 3f74ec0
commit b930d21
Show file tree

Hide file tree

Showing 5 changed files with 68 additions and 5 deletions.
diff --git a/go/models/function_route.go b/go/models/function_route.go
diff --git a/go/porcelain/deploy.go b/go/porcelain/deploy.go
@@ -799,6 +799,7 @@ func bundleFromManifest(ctx context.Context, manifestFile *os.File, observer Dep
 				Pattern:    route.Pattern,
 				Literal:    route.Literal,
 				Expression: route.Expression,
+				Methods:    route.Methods,
 			}
 		}
 

diff --git a/go/porcelain/deploy_test.go b/go/porcelain/deploy_test.go
@@ -480,7 +480,8 @@ func TestBundleWithManifest(t *testing.T) {
 					},
 					{
 						"pattern": "/products/:id",
-						"expression": "^/products/(.*)$"
+						"expression": "^/products/(.*)$",
+						"methods": ["GET", "POST"]
 					}
 				]
 			},
@@ -525,6 +526,7 @@ func TestBundleWithManifest(t *testing.T) {
 	assert.Equal(t, "/products/:id", helloJSConfig.Routes[1].Pattern)
 	assert.Empty(t, helloJSConfig.Routes[1].Literal)
 	assert.Equal(t, "^/products/(.*)$", helloJSConfig.Routes[1].Expression)
+	assert.Equal(t, []string{"GET", "POST"}, helloJSConfig.Routes[1].Methods)
 }
 
 func TestReadZipRuntime(t *testing.T) {

diff --git a/go/porcelain/functions_manifest.go b/go/porcelain/functions_manifest.go
@@ -20,7 +20,8 @@ type functionsManifestEntry struct {
 }
 
 type functionRoute struct {
-	Pattern    string `json:"pattern"`
-	Literal    string `json:"literal"`
-	Expression string `json:"expression"`
+	Pattern    string   `json:"pattern"`
+	Literal    string   `json:"literal"`
+	Expression string   `json:"expression"`
+	Methods    []string `json:"methods"`
 }
diff --git a/swagger.yml b/swagger.yml
@@ -3632,7 +3632,12 @@ definitions:
       literal:
         type: string
       expression:
-        type: string          
+        type: string    
+      methods:
+        type: array
+        items:
+          type: string
+          enum: ['GET', 'POST', 'PUT', 'PATCH', 'DELETE', 'OPTIONS']
 parameters:
   page:
     type: integer