Fix float validation using decimal.Decimal #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just ran some tests against this PR, looks like it solves the issues along with the |
All good! This was fun to reverse-engineer! |
mjpereira602
pushed a commit
to mjpereira602/devicetype-library
that referenced
this pull request
Feb 22, 2023
* Fix float validation using decimal.Decimal * Force string repr of the float when loading yaml --------- Co-authored-by: Jonathan Senecal <[email protected]>
mjpereira602
pushed a commit
to mjpereira602/devicetype-library
that referenced
this pull request
Mar 1, 2023
* Fix float validation using decimal.Decimal * Force string repr of the float when loading yaml --------- Co-authored-by: Jonathan Senecal <[email protected]>
etherwrangler
pushed a commit
to etherwrangler/devicetype-library
that referenced
this pull request
Jul 16, 2023
* Fix float validation using decimal.Decimal * Force string repr of the float when loading yaml --------- Co-authored-by: Jonathan Senecal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decimal.Decimalin order to catch inconsistencies with operations against floats in PythonDecimalSafeLoaderto deserialize YAML floats asdecimal.DecimalRefResolverin order to also castdecimal.Decimalto floats loaded through a $ref.Closes #1068