Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weight Validation #1068

Closed
danner26 opened this issue Jan 26, 2023 · 2 comments · Fixed by #1069 or #1073
Closed

Weight Validation #1068

danner26 opened this issue Jan 26, 2023 · 2 comments · Fixed by #1069 or #1073

Comments

@danner26
Copy link
Member

During validation of a new addition seen in PR #1067, @mayafox noticed that using a weight of 10.11 would return an invalid configuration, when in fact 10.11 is a multipleOf 0.01.
@danner26 danner26 mentioned this issue Jan 26, 2023
Merged
@danner26 danner26 linked a pull request Jan 26, 2023 that will close this issue
Weight Validation Fix #1069
Merged
@danner26
Copy link
Member Author

For future reference, as stated in the PR, this is fixed by using multipleOfPrecision instead of multipleOf, as discovered via this jsonschema issue

@cwegener cwegener mentioned this issue Jan 30, 2023
Closed
@danner26 danner26 reopened this Jan 30, 2023
@danner26
Copy link
Member Author

Thanks to the people over at jsonschema, in this issue we should have a working solution now. Testing the implemention now

@danner26 danner26 mentioned this issue Jan 30, 2023
Closed
@jsenecal jsenecal mentioned this issue Jan 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@danner26