Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify dropping python2 support in meld.profile #3167

Merged
merged 2 commits into from
Jan 27, 2020
Merged

clarify dropping python2 support in meld.profile #3167

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc97627
clarify dropping python2 support in meld.profile
glitsj16 Jan 18, 2020
58f1f72
properly comment the python2 situation in meld
glitsj16 Jan 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions etc/meld.profile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ noblacklist ${HOME}/.ssh
noblacklist ${HOME}/.subversion

# Allow python (blacklisted by disable-interpreters.inc)
# Python 2 is EOL (see #3164). Uncomment the next line (or put it into your meld.local) if you understand the risks but want python 2 support for older meld versions.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Python 2 is EOL (see #3164). Uncomment the next line (or put it into your meld.local) if you understand the risks but want python 2 support for older meld versions.
# Python 2 is EOL (see #3164). Uncomment the next line (or put it into your meld.local) if you understand the risks but want python 2 support for older meld versions.
#include allow-python2.inc

Copy link
Collaborator Author

@glitsj16 glitsj16 Jan 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe, my subconscious python2 love showed itself... Nice catch, and more importantly, nice job proposing this in #3164 in the first place 👍.
Do note this is only a suggestion, it is not up to me to force anything regarding the python2 EOL issue? Just so things are in the clear :)

include allow-python3.inc

# Uncomment the next line (or put it into your meld.local) if you don't need to compare files in disable-common.inc.
Expand Down