clarify dropping python2 support in meld.profile #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusty-snake
reviewed
Jan 19, 2020
| @@ -22,6 +22,7 @@ noblacklist ${HOME}/.ssh | |||
| noblacklist ${HOME}/.subversion | |||
|
|
|||
| # Allow python (blacklisted by disable-interpreters.inc) | |||
| # Python 2 is EOL (see #3164). Uncomment the next line (or put it into your meld.local) if you understand the risks but want python 2 support for older meld versions. | |||
There was a problem hiding this comment.
Suggested change
| # Python 2 is EOL (see #3164). Uncomment the next line (or put it into your meld.local) if you understand the risks but want python 2 support for older meld versions. | |
| # Python 2 is EOL (see #3164). Uncomment the next line (or put it into your meld.local) if you understand the risks but want python 2 support for older meld versions. | |
| #include allow-python2.inc |
There was a problem hiding this comment.
Hehe, my subconscious python2 love showed itself... Nice catch, and more importantly, nice job proposing this in #3164 in the first place 👍.
Do note this is only a suggestion, it is not up to me to force anything regarding the python2 EOL issue? Just so things are in the clear :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a suggestion relating to the discussion on dropping support for python2 in #3164.