fix: missing setContext when using logger: false #2243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
HealthIndicator assumes it gets a ConsoleLogger, but TERMINUS_LOGGER is only guaranteed to be an instance of LoggerService which doesn't have a setContext method. This breaks when using logger: false.
Same issue that was fixed in #2225 but for health-indicator/http
Issue Number: N/A
What is the new behavior?
Avoid crash by checking that logger is instance of ConsoleLogger before calling setContext
Does this PR introduce a breaking change?
Other information