fix: Fix crash when setting logger to false #2225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When setting up the terminus module with logging disabled according to the documentation:
the application will crash, with the following error:
This is caused by incorrect typing of the logger injected into
HealthCheckService
. It's typed to be aConsoleLogger
, which is why it looks safe to callsetContext
.This is not true when passing
{logger: false}
, and probably not when using a customer logger either.What is the new behavior?
Setting up the terminus module with logging disabled no longer crashes the app :)
If a
ConsoleLogger
is provided, we still callsetContext
in order to preserve the old behavior. I guess we could consider callingsetContext
as long as it exists on the logger object instead?Does this PR introduce a breaking change?
Other information