Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclusive minimum and exclusive maximum are numbers #2909

Merged

Conversation

mastermatt
Copy link

Reopening #1162 from @zobzn.
Originally, the PR couldn't be merged as the OpenAPI Validator didn't support the new spec. #1167 (comment)
More than three years on, I'm hoping this is no longer an issue.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #1162

What is the new behavior?

exclusiveMinimum and exclusiveMaximum can now be provided as either a bool or number, to support the newer spec.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec kamilmysliwiec merged commit d675211 into nestjs:master Jul 1, 2024
@kamilmysliwiec
Copy link
Member

lgtm

@kamilmysliwiec
Copy link
Member

Nope it's still broken #2994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants