Merge pull request #2909 from mastermatt/fix-exclusive-min-max-types

fix: exclusive minimum and exclusive maximum are numbers
nestjs · Jul 1, 2024 · d675211 · d675211
2 parents b7eeffd + ba62457
commit d675211
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 14 deletions.
diff --git a/e2e/api-spec.json b/e2e/api-spec.json
@@ -286,10 +286,8 @@
             "required": true,
             "in": "query",
             "schema": {
-              "minimum": 0,
-              "maximum": 10000,
-              "exclusiveMaximum": true,
-              "exclusiveMinimum": true,
+              "exclusiveMinimum": 0,
+              "exclusiveMaximum": 10000,
               "title": "Page",
               "format": "int32",
               "default": 0,
@@ -483,10 +481,8 @@
             "in": "query",
             "required": true,
             "schema": {
-              "minimum": 0,
-              "maximum": 10000,
-              "exclusiveMaximum": true,
-              "exclusiveMinimum": true,
+              "exclusiveMinimum": 0,
+              "exclusiveMaximum": 10000,
               "title": "Page",
               "format": "int32",
               "default": 0,

diff --git a/e2e/src/cats/dto/pagination-query.dto.ts b/e2e/src/cats/dto/pagination-query.dto.ts
@@ -8,11 +8,9 @@ export enum LettersEnum {
 
 export class PaginationQuery {
   @ApiProperty({
-    minimum: 0,
-    maximum: 10000,
+    exclusiveMinimum: 0,
+    exclusiveMaximum: 10000,
     title: 'Page',
-    exclusiveMaximum: true,
-    exclusiveMinimum: true,
     format: 'int32',
     default: 0
   })

diff --git a/lib/interfaces/open-api-spec.interface.ts b/lib/interfaces/open-api-spec.interface.ts
@@ -219,9 +219,9 @@ export interface SchemaObject {
   title?: string;
   multipleOf?: number;
   maximum?: number;
-  exclusiveMaximum?: boolean;
+  exclusiveMaximum?: boolean | number;
   minimum?: number;
-  exclusiveMinimum?: boolean;
+  exclusiveMinimum?: boolean | number;
   maxLength?: number;
   minLength?: number;
   pattern?: string;