-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GRPC: Fix credentials and introduce arguments #4607
Conversation
Pull Request Test Coverage Report for Build 23046
💛 - Coveralls |
What do you think about copying/mimicking options from this file: |
...maxMessageLengthOptions, | ||
...keepaliveOptions, | ||
}; | ||
|
||
const credentials = | ||
options.credentials || grpcPackage.credentials.createInsecure(); | ||
this.options.credentials || grpcPackage.credentials.createInsecure(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this fix is quite important, I'll push it as a separate commit
Hm, what about exporting the internally used grpc package? This will:
|
Although, I'd love to do it, |
# Conflicts: # packages/microservices/client/client-grpc.ts
@kamilmysliwiec Finally, I've fixed the tests 😅 |
Thank you! |
🤦 Just FYI: I've clicked "Close" by accident, but your PR has already been merged! I can't reopen now since the "These commits are already merged" shows up |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
GRPC credentials were completly ignored on client side. It was no more possible to establish a secure SSL GRPC-connection. Further, it was no more possible to pass GRPC-arguments
Issue Number: #4597
What is the new behavior?
GRPC-credentials work again (as they have in Nestjs6). Additionaly, an
argument
parameter was added to the GRPC options, to pass any of the arguments defined in https://grpc.github.io/grpc/core/group__grpc__arg__keys.htmlDoes this PR introduce a breaking change?