Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Additional GRPC options can't be set anymore in Nestjs 7 #4597

Closed
sjkummer opened this issue Apr 14, 2020 · 3 comments
Closed

Regression: Additional GRPC options can't be set anymore in Nestjs 7 #4597

sjkummer opened this issue Apr 14, 2020 · 3 comments

Comments

@sjkummer
Copy link
Contributor

Bug Report

Original behavior in Nestjs 6

In Nestjs 6, it was possible to set all GRPC options, e.g. grpc.ssl_target_name_override and grpc.default_authority which are required to have GRPC-SSL enabled on localhost:

const grpcOptionsAny: any = grpcClientOptions.options;
grpcOptionsAny['grpc.ssl_target_name_override'] = 'localhost';
grpcOptionsAny['grpc.default_authority'] = 'localhost';

Breaking change

The commit 0b38029 changed this behavior by removing ...this.options from the used option-Object:

0b38029#r38494866

Now, most of the GRPC-options are unavailable when using Nestjs:
https://grpc.github.io/grpc/core/group__grpc__arg__keys.html

@sjkummer sjkummer added the needs triage This issue has not been looked into label Apr 14, 2020
@kamilmysliwiec
Copy link
Member

Would you like to create a PR for this issue? Perhaps, we should also add other missing gRPC options to the GrpcOptions interface (to avoid as any cast). Would you be interested in contributing to this?

@kamilmysliwiec kamilmysliwiec added scope: microservices and removed needs triage This issue has not been looked into labels Apr 15, 2020
@sjkummer
Copy link
Contributor Author

@kamilmysliwiec The list of GRPC options is quite long, but I can do an easy PR which will at least avoid casting.

@kamilmysliwiec
Copy link
Member

Added in 7.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants