Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(sample/31): fix wrong port number in README #11954

Merged
merged 1 commit into from
Jul 3, 2023
Merged

docs(sample/31): fix wrong port number in README #11954

merged 1 commit into from
Jul 3, 2023

Conversation

NilsMoller
Copy link

@NilsMoller NilsMoller commented Jul 1, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Documentation update

What is the current behavior?

Following the README leads you to the wrong gateway link.

What is the new behavior?

The link in the README is correct.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This was a regression after this PR fixed a version problem with sample 31.

@coveralls
Copy link

Pull Request Test Coverage Report for Build b7780d28-b81b-41b2-9e2c-e1552d25dacf

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.864%

Totals Coverage Status
Change from base Build df8ed325-8a47-4e91-8f33-ed2a1e33d5d1: 0.0%
Covered Lines: 6364
Relevant Lines: 6853

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit 9defd79 into nestjs:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants