Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample(31-graphql-federation-code-first): downgraded the @apollo/subgraph and @apollo/gateway versions #11950

Conversation

Tony133
Copy link
Contributor

@Tony133 Tony133 commented Jun 30, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number:
#11799
#11942

What is the new behavior?

Proposal:

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Using version 2.2.3 of the following packages:

  • @apollo/gateway
  • @apollo/subgraph

in the code first mode the following error is not generated:

sample/31-graphql-federation-code-first/users-application/node_modules/@apollo/federation-internals/src/error.ts:66 super( ^ GraphQLError: The schema is not a valid GraphQL schema.. Caused by: Invalid definition for directive "@tag": "@tag" should have locations FIELD_DEFINITION, OBJECT, INTERFACE, UNION, ARGUMENT_DEFINITION, SCALAR, ENUM, ENUM_VALUE, INPUT_OBJECT, INPUT_FIELD_DEFINITION, but found (non-subset) FIELD_DEFINITION, OBJECT, INTERFACE, UNION, ARGUMENT_DEFINITION, SCALAR, ENUM, ENUM_VALUE, INPUT_OBJECT, INPUT_FIELD_DEFINITION, SCHEMA 

Updating the the packages to versions greater than v2.2.3 generates the error by not being able to make the example work.

This is currently a solution to solve this problem.

However there is an open issue in the apollographql federation repository regarding this issue see here: apollographql/federation#2375

@coveralls
Copy link

Pull Request Test Coverage Report for Build fe0e1717-3c71-4ad6-996c-f9ed8fa4fec5

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.864%

Totals Coverage Status
Change from base Build a1a73cb7-c299-414e-9a73-4ef4cbc008ed: 0.0%
Covered Lines: 6364
Relevant Lines: 6853

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit f965c41 into nestjs:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants