Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition version handling to proper semantic versioning when building from Git and release tarballs #2715

Merged
merged 6 commits into from
Apr 27, 2023
Merged

Transition version handling to proper semantic versioning when building from Git and release tarballs #2715

merged 6 commits into from
Apr 27, 2023

Conversation

jougs
Copy link
Contributor

@jougs jougs commented Apr 27, 2023

Fixes #2003 and by providing the basic NEST version in a new file VERSION in the top-level source directory.

Fixes #2116 by specifying a proper semantic version as major.minor.patch-post0.dev0 in the repository. The -post0.dev0 suffix will be removed from releases.

This PR also removes the possibility to set a custom version suffix for builds with the -Dwith-version-suffix switch for CMake as that is now easily possible with the new mechanism based on the VERSION file. Less redundancy = more better.

@jougs jougs added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know labels Apr 27, 2023
@jougs jougs requested review from terhorstd and Helveg April 27, 2023 06:11
@jougs jougs self-assigned this Apr 27, 2023
Helveg
Helveg suggested changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@Helveg Helveg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo. I find remote a confusing name for the remote branch. What about remote_branch instead?

build_support/version_info.sh Outdated Show resolved Hide resolved
@jougs @Helveg
Update build_support/version_info.sh
2beb5c4 
Co-authored-by: Robin De Schepper <[email protected]>
jougs
jougs commented Apr 27, 2023
View reviewed changes
build_support/version_info.sh Outdated Show resolved Hide resolved
@jougs
Copy link
Contributor Author

jougs commented Apr 27, 2023

@Helveg: remote is really the name of the remote (as set when git remote adding it). Not sure there's any better name for it...

jougs
jougs commented Apr 27, 2023
View reviewed changes
cmake/NestVersionInfo.cmake Outdated Show resolved Hide resolved
@Helveg Helveg merged commit 257620c into nest:master Apr 27, 2023
@Helveg Helveg deleted the cleanup branch April 27, 2023 12:34
@jougs jougs removed the request for review from terhorstd April 27, 2023 12:39
@jougs jougs mentioned this pull request May 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Helveg Helveg Helveg approved these changes

Assignees

@jougs jougs

Labels
I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
Build system and CI
Status: Done
Milestone
No milestone
2 participants
@jougs @Helveg