Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyNEST's setup.py version does not comply with PEP440 #2003

Closed
Helveg opened this issue Apr 8, 2021 · 5 comments · Fixed by #2715
Closed

PyNEST's setup.py version does not comply with PEP440 #2003

Helveg opened this issue Apr 8, 2021 · 5 comments · Fixed by #2715
Assignees
@Helveg
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Maintenance Work to keep up the quality of the code and documentation.

Comments

@Helveg
Copy link
Contributor

Helveg commented Apr 8, 2021 •
edited
Loading

Describe the bug
The setup.py produced by CMake contains invalid version specifiers such as python-cmake@6b17f32b1 which do not comply with PEP440 and lead to warnings in #1959 :

/home/robin/.pyenv/versions/3.9.0/envs/nest/lib/python3.9/site-packages/setuptools/dist.py:472: UserWarning: The version specified ('python-cmake@6b17f32b1') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI.
@stinebuu stinebuu added I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Apr 20, 2021
@terhorstd terhorstd mentioned this issue May 21, 2021
Merged
@heplesser
Copy link
Contributor

Fixed in NEST 3, closing.

@heplesser heplesser reopened this Jun 30, 2021
@github-actions
Copy link

github-actions bot commented Sep 3, 2021

Issue automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Sep 3, 2021
@Helveg
Copy link
Contributor Author

Helveg commented Jan 28, 2022 •
edited
Loading

  • A sanitized version should be made available to Python, during release workflows, to be packaged.
  • It should be immediately clear from the Python version whether it is an official release
    • Append a monotonically increasing dev tag to all source builds ran by users.
  • Full version debugging info should be made readily available from the Python API nest.version_info(), so that the need for git-branch@git-commit is filled in (for profiling, benchmarking, debugging, issue reporting).

@github-actions github-actions bot removed the stale Automatic marker for inactivity, please have another look here label Jan 29, 2022
@github-actions
Copy link

Issue automatically marked stale!

@github-actions github-actions bot added stale Automatic marker for inactivity, please have another look here and removed stale Automatic marker for inactivity, please have another look here labels Mar 30, 2022
@github-actions
Copy link

Issue automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label May 30, 2022
@jougs jougs mentioned this issue Apr 27, 2023
Merged
@jessica-mitchell jessica-mitchell moved this to Done in PyNEST-NG Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Helveg Helveg

Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Maintenance Work to keep up the quality of the code and documentation.
Projects
PyNEST-NG
Status: Done
Milestone
No milestone
3 participants
@heplesser @stinebuu @Helveg