add ability to instance socket connection in order to test multiple connections #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConnorRigby
force-pushed
the
load-test
branch
6 times, most recently
from
ce07fd8
to
d9a35f4
Compare
jjcarstens
reviewed
Jun 28, 2023
|
|
||
| @doc """ | ||
| Send an update status to web | ||
| """ | ||
| @spec send_update_status(String.t() | atom()) :: :ok | ||
| defdelegate send_update_status(status), to: Socket | ||
| def send_update_status(status), do: Socket.send_update_status(Socket, status) |
There was a problem hiding this comment.
Suggested change
| def send_update_status(status), do: Socket.send_update_status(Socket, status) | |
| defdelegate send_update_status(socket \\ Socket, status), to: Socket |
I'm pretty sure you can delegate the default and it would work with dialyzer as well
| @spec reconnect() :: :ok | ||
| defdelegate reconnect(), to: Socket | ||
| @spec reconnect_socket() :: :ok | ||
| def reconnect_socket(), do: Socket.reconnect_socket(Socket) |
There was a problem hiding this comment.
Is there a specific reason for this change? This could be considered breaking since reconnect() has been around a while
There was a problem hiding this comment.
yeah use Slipstream imports a reconnect/2 function. We could make NervesHubLink.reconnect stay the same while the socket module remains the new function.
There was a problem hiding this comment.
I don't think we need a load test file. This is basic enough that those testing can implement what they need and we can skip adding a file thats not used in production
…onnections Signed-off-by: Connor Rigby <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.