-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to instance socket connection in order to test multiple connections #127
Open
ConnorRigby
wants to merge
1
commit into
main
Choose a base branch
from
load-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -6,47 +6,47 @@ defmodule NervesHubLink do | |||||
""" | ||||||
@spec connected? :: boolean() | ||||||
def connected?() do | ||||||
Socket.check_connection(:device) | ||||||
Socket.check_connection(Socket, :device) | ||||||
end | ||||||
|
||||||
def console_connected?() do | ||||||
Socket.check_connection(:console) | ||||||
Socket.check_connection(Socket, :console) | ||||||
end | ||||||
|
||||||
@doc """ | ||||||
Checks if the device has a socket connection with NervesHub | ||||||
""" | ||||||
def socket_connected?() do | ||||||
Socket.check_connection(:socket) | ||||||
Socket.check_connection(Socket, :socket) | ||||||
end | ||||||
|
||||||
@doc """ | ||||||
Return whether there's currently an active console session | ||||||
""" | ||||||
@spec console_active?() :: boolean() | ||||||
defdelegate console_active?, to: Socket | ||||||
def console_active?, do: Socket.console_active?(Socket) | ||||||
|
||||||
@doc """ | ||||||
Current status of the update manager | ||||||
""" | ||||||
@spec status :: NervesHubLink.UpdateManager.State.status() | ||||||
defdelegate status(), to: NervesHubLink.UpdateManager | ||||||
def status(), do: NervesHubLink.UpdateManager.status(Socket) | ||||||
|
||||||
@doc """ | ||||||
Restart the socket and device channel | ||||||
""" | ||||||
@spec reconnect() :: :ok | ||||||
defdelegate reconnect(), to: Socket | ||||||
@spec reconnect_socket() :: :ok | ||||||
def reconnect_socket(), do: Socket.reconnect_socket(Socket) | ||||||
|
||||||
@doc """ | ||||||
Send update progress percentage for display in web | ||||||
""" | ||||||
@spec send_update_progress(non_neg_integer()) :: :ok | ||||||
defdelegate send_update_progress(progress), to: Socket | ||||||
def send_update_progress(progress), do: Socket.send_update_progress(Socket, progress) | ||||||
|
||||||
@doc """ | ||||||
Send an update status to web | ||||||
""" | ||||||
@spec send_update_status(String.t() | atom()) :: :ok | ||||||
defdelegate send_update_status(status), to: Socket | ||||||
def send_update_status(status), do: Socket.send_update_status(Socket, status) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
I'm pretty sure you can delegate the default and it would work with dialyzer as well |
||||||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason for this change? This could be considered breaking since
reconnect()
has been around a whileThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah
use Slipstream
imports areconnect/2
function. We could makeNervesHubLink.reconnect
stay the same while the socket module remains the new function.