Make WaitForMultipleEvents atomic when waitAll is true
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mqudsi
force-pushed
the
atomic_wait_all
branch
3 times, most recently
from
22696a0 to
2db23ff
Compare
mqudsi
force-pushed
the
atomic_wait_all
branch
3 times, most recently
from
abdcdb0 to
63fd4f1
Compare
mqudsi
force-pushed
the
atomic_wait_all
branch
9 times, most recently
from
bfe1059 to
ea53586
Compare
Test contributed by @qwertymaster617, see [0] for associated issue. [0]: #9
This patch significantly changes the behavior (and to an extent, the performance) of pevents to more closely mimic the documented behavior of `WaitForMultipleObjects` and `WaitForMultipleObjectsEx`. As reported in #9, the previous behavior did not make any atomicity guarantees when a call to `WaitForMultipleEvents()` was made with `waitAll = true`, and WFME would attempt to serially obtain the events in question, which could lead to a deadlock in case of circular locking and auto-reset events. The WFMO behavior documented on MSDN makes it clear that the Windows implementation does not modify the signalled state of any of the manual or auto reset events being awaited until the WFMO call is ready to return, at which point either the one event in question or all the events being awaited (dependent on `waitAll`) are atomically awaited.
If the initial number of events was zero and waitAll was set, this assertion would fail incorrectly.
mqudsi
force-pushed
the
atomic_wait_all
branch
from
ea53586 to
bc97237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch significantly changes the behavior (and to an extent, the
performance) of pevents to more closely mimic the documented behavior of
WaitForMultipleObjectsandWaitForMultipleObjectsEx.As reported in #9, the previous behavior did not make any atomicity
guarantees when a call to
WaitForMultipleEvents()was made withwaitAll = true, and WFME would attempt to serially obtain the eventsin question, which could lead to a deadlock in case of circular locking
and auto-reset events.
The WFMO behavior documented on MSDN makes it clear that the Windows
implementation does not modify the signalled state of any of the manual
or auto reset events being awaited until the WFMO call is ready to
return, at which point either the one event in question or all the
events being awaited (dependent on
waitAll) are atomically awaited.Closes #9