-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream pevents changes, early testing or feedback requested #130191
Comments
I checked our code base and the yarn.lock and couldn't find any reference to @bpasero assigning to you since you usually know more about use using native libraries. Feel free to close if my investigation was correct. |
This is the first time I hear about the library, so moving back to you to decide whether an action is needed on our end. |
I think it was in vscode-cpptools, see sample stack trace from macOS below (this is not recent):
|
@sean-mcmanus FYI. I will close the issue since VS Code core is not using the library. |
Sorry, I didn't realize it wasn't a monorepo. Can you move this to https://github.com/microsoft/vscode-cpptools and reopen? |
@mqudsi I tried but I couldn't. Surprisingly I don't have rights to move it there :-(. |
Hello team,
I'm the author of pevents, the WIN32 manual/auto-reset events library for Linux. To my knowledge, VS Code is (or was) one of the bigger projects depending on pevents; iirc it was used in some of the language-specific extensions.
There's a fairly large change that's been finalized and is ready for merging into master, but I was wondering if someone from the team working on the extensions that use pevents could get in touch. Presumably your project has some LSP unit/integration tests that cover multithreaded synchronization; it would be great if I could get an all-ok that everything continues to work fine with the latest changes. Given the nature of multithreaded code (especially with optimizations enabled) it's extremely tricky to validate architectural changes to synchronization primitives, even with all the unit and regression tests passing on our end. Having further real-world verification would be great, and in case any issues arise, hopefully it would be better than you guys updating to master and having your production release randomly fail.
The text was updated successfully, but these errors were encountered: