Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Properly convert legacy MoveNodeMappings #5070

Merged
merged 1 commit into from
May 19, 2024

Conversation

nezaniel
Copy link
Member

…to InterdimensionalSiblings

resolves #5056

This solves the regression introduced in #4993 by properly evaluating the legacy MoveNodeMappings payload array. Respective tests have been added.

Upgrade instructions

none

Review instructions

none

Checklist

  • Code follows the PSR-12 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to relay again ;) Thx for the unit test!

Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really judge nor test this, but it has the right vibe to it :D

@bwaidelich bwaidelich merged commit bb3aa5c into 9.0 May 19, 2024
10 checks passed
@bwaidelich bwaidelich deleted the 5056-legacyNodeAggregateWasMovedDeserialization branch May 19, 2024 09:59
mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this pull request Jun 19, 2024
neos-bot pushed a commit to neos/contentrepository-core that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Neos9-beta10 old NodeAggregateWasMoved cannot be normalized
3 participants